[8.4] Add polyfill for ReflectionConstant
#524
Merged
+325
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielEScherzer
changed the title
DanielEScherzer
force-pushed
the
ReflectionConstant
branch
from
beac2d2 to
942f64e
Compare
|
All failures and errors are unrelated in the PHPUnit tests (mostly mbstring and Grapheme related) |
|
Wow, I didn't think it will be possible to polyfill |
xabbuh
reviewed
May 14, 2025
OskarStark
changed the title
ReflectionConstant
stof
requested changes
May 14, 2025
DanielEScherzer
force-pushed
the
ReflectionConstant
branch
3 times, most recently
from
d2351b5 to
610bba8
Compare
|
@fabpot is there anything I can do to move this forward? |
nicolas-grekas
force-pushed
the
ReflectionConstant
branch
2 times, most recently
from
7243e0d to
2d152f8
Compare
nicolas-grekas
force-pushed
the
ReflectionConstant
branch
from
2d152f8 to
c4a2ffa
Compare
|
Thank you @DanielEScherzer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.